Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use customized repositories #1133

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: Use customized repositories #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ for more information.

`rules_jvm_external_deps` uses a default list of maven repositories to download
`rules_jvm_external`'s own dependencies from. Should you wish to change this,
use the `repositories` parameter:
use the `repositories` parameter, generate your own `rules_jvm_external_deps_install.json` by
running `REPIN=1 bazel run @unpinned_rules_jvm_external_deps//:pin` and commit the file to your
version control system (note that at this point you will need to maintain your customized
`rules_jvm_external_deps_install.json`):

```python
rules_jvm_external_deps(repositories = ["https://mycorp.com/artifacts"])
Expand Down
2 changes: 1 addition & 1 deletion repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def rules_jvm_external_deps(repositories = _DEFAULT_REPOSITORIES):
"org.slf4j:slf4j-simple:2.0.12",
"software.amazon.awssdk:s3:2.25.23",
],
maven_install_json = "@rules_jvm_external//:rules_jvm_external_deps_install.json",
maven_install_json = "@rules_jvm_external//:rules_jvm_external_deps_install.json" if repositories == _DEFAULT_REPOSITORIES else "@//:rules_jvm_external_deps_install.json",
fail_if_repin_required = True,
strict_visibility = True,
fetch_sources = True,
Expand Down