Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run buildifier. No logical changes #658

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Run buildifier. No logical changes #658

merged 1 commit into from
Jan 27, 2022

Conversation

shs96c
Copy link
Collaborator

@shs96c shs96c commented Jan 18, 2022

This is a formatting-only change, created by running:

buildifier -r -lint fix .

cheister
cheister approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@cheister cheister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In buildifier we trust

@shs96c
Copy link
Collaborator Author

shs96c commented Jan 19, 2022

I'm waiting for #646, #648, and #649 to be resolved before landing, and this is quite a disruptive change.

@shs96c
Run buildifier. No logical changes
5e7d35b 
This is a formatting-only change, created by running:

buildifier -r -lint fix  .
@shs96c shs96c merged commit 9278777 into bazel-contrib:master Jan 27, 2022
@shs96c shs96c deleted the buildifier branch January 27, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheister cheister cheister approved these changes

@jin jin jin approved these changes

@c-parsons c-parsons Awaiting requested review from c-parsons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shs96c @jin @cheister