Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the implementation of maven_publish "not private" #849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make the implementation of maven_publish "not private" #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions private/rules/maven_publish.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ MavenPublishInfo = provider(
"javadocs": "Javadoc jar file for documentation files",
"artifact_jar": "Jar with the code and metadata for execution",
"source_jar": "Jar with the source code for review",
"target": "The original `Label` that is being published",
},
)

Expand All @@ -14,7 +15,7 @@ echo "Uploading {coordinates} to {maven_repo}"
{uploader} {maven_repo} {gpg_sign} {user} {password} {coordinates} {pom} {artifact_jar} {source_jar} {javadoc}
"""

def _maven_publish_impl(ctx):
def maven_publish_impl(ctx):
executable = ctx.actions.declare_file("%s-publisher" % ctx.attr.name)

maven_repo = ctx.var.get("maven_repo", "''")
Expand Down Expand Up @@ -72,7 +73,7 @@ def _maven_publish_impl(ctx):
]

maven_publish = rule(
_maven_publish_impl,
maven_publish_impl,
doc = """Publish artifacts to a maven repository.

The maven repository may accessed locally using a `file://` URL, or
Expand Down