Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra yarn_installs #1152

Closed
gregmagolan opened this issue Sep 19, 2019 · 0 comments · Fixed by #1159
Closed

Remove extra yarn_installs #1152

gregmagolan opened this issue Sep 19, 2019 · 0 comments · Fixed by #1159
Milestone
1.0

Comments

@gregmagolan
Copy link
Collaborator

  • build_bazel_rules_typescript_devserver_deps should go
  • build_bazel_rules_typescript_protobufs_compiletime_deps is going into labs along to ts_proto_library
@gregmagolan gregmagolan added this to the 1.0 milestone Sep 19, 2019
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 20, 2019
@alexeagle
refactor: move ts_proto_library to @bazel/labs
7b51f9d 
We don't intend to fully support this for 1.0
Also remove a nested install, by vendoring the one file we need for ts_devserver

Fixes bazel-contrib#1152
Fixes bazel-contrib#1151
@alexeagle alexeagle mentioned this issue Sep 20, 2019
Merged
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 20, 2019
@alexeagle
refactor: move ts_proto_library to @bazel/labs
202468e 
We don't intend to fully support this for 1.0
Also remove a nested install, by vendoring the one file we need for ts_devserver

Fixes bazel-contrib#1152
Fixes bazel-contrib#1151
alexeagle added a commit to alexeagle/rules_nodejs that referenced this issue Sep 20, 2019
@alexeagle
refactor: move ts_proto_library to @bazel/labs
bae9c8e 
We don't intend to fully support this for 1.0
Also remove a nested install, by vendoring the one file we need for ts_devserver

Fixes bazel-contrib#1152
Fixes bazel-contrib#1151
alexeagle added a commit that referenced this issue Sep 20, 2019
@alexeagle
refactor: move ts_proto_library to @bazel/labs (#1159)
a2c6468 
We don't intend to fully support this for 1.0
Also remove a nested install, by vendoring the one file we need for ts_devserver

Fixes #1152
Fixes #1151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

refactor: move ts_proto_library to @bazel/labs alexeagle/rules_nodejs
1 participant
@gregmagolan