Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an output group for ts_project that contains DeclarationInfo #1978

Closed
longlho opened this issue Jun 29, 2020 · 2 comments
Closed

Provide an output group for ts_project that contains DeclarationInfo #1978

longlho opened this issue Jun 29, 2020 · 2 comments

Comments

@longlho
Copy link
Contributor

longlho commented Jun 29, 2020

🚀 feature request

Relevant Rules

ts_project

Description

Right now there are tooling like @microsoft/api-extractor that bundles type definitions into a single d.ts (kinda like rollup for d.ts). However, ts_project doesn't not export its type definitions so it'd be great if it does that either by default or an output group.

I'm probably looking for type definitions to be included in DefaultInfo otherwise I don't think npm_package_bin can read it as data?

Describe the solution you'd like

It'd be great if it does that either by default or an output group

Describe alternatives you've considered

Custom rules to extract DeclarationInfo out of ts_project

@longlho longlho changed the title Provider an output group for ts_project that contains d.ts Provider an output group for ts_project that contains DeclarationInfo Jun 29, 2020
@longlho longlho changed the title Provider an output group for ts_project that contains DeclarationInfo Provide an output group for ts_project that contains DeclarationInfo Jun 29, 2020
@alexeagle
Copy link
Collaborator

Great point, you shouldn't have to write a rule just to consume the DeclarationInfo. filegroup with output groups is the simple API for a consumer to select the outputs they want. This should be easy so maybe a good training issue for anyone who wants to contribute - I can give some pointers where to look.

@longlho
Copy link
Contributor Author

longlho commented Jun 29, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants