Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg_npm should produce a tar output, not just runnable .pack target #2339

Closed
alexeagle opened this issue Dec 8, 2020 · 1 comment · Fixed by #2366
Closed

pkg_npm should produce a tar output, not just runnable .pack target #2339

alexeagle opened this issue Dec 8, 2020 · 1 comment · Fixed by #2366
Assignees
@alexeagle
Labels
enhancement

Comments

@alexeagle
Copy link
Collaborator

No description provided.

@alexeagle alexeagle added this to the 3.0 milestone Dec 8, 2020
@alexeagle alexeagle self-assigned this Dec 8, 2020
@mattem mattem mentioned this issue Dec 8, 2020
Closed
@alexeagle alexeagle removed this from the 3.0 milestone Dec 15, 2020
@alexeagle alexeagle mentioned this issue Dec 15, 2020
Closed
@alexeagle
Copy link
Collaborator Author

Note as a workaround, you can use the .pack runnable as the "tool" input to an npm_package_bin in order to convert it to an action.

@mattem mattem linked a pull request Jan 23, 2021 that will close this issue
feat: add support for NodeJS 15.x #2366
Merged
@mattem mattem mentioned this issue Jan 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for NodeJS 15.x mattem/rules_nodejs
2 participants
@alexeagle @mattem