Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Node v15.0.0 #2268

Closed
wants to merge 11 commits into from
Closed

feat: add Node v15.0.0 #2268

wants to merge 11 commits into from

Conversation

mattem
Copy link
Collaborator

@mattem mattem commented Nov 4, 2020 •
edited
Loading

Updates the Vue and vendored_node to Node v15.0.1 to use npm 7

reference: #2256

Alex Eagle and others added 11 commits October 17, 2020 16:09
@alexeagle
fix(builtin): give a longer timeout for _create_build_files
e72c145 
A user reports that their build file generation takes longer than 600 seconds.
It's probably a bug that we are so slow, but let's address that separately (maybe in our work for npm v7)

Also note we could have made this timeout user-configurable, but I think the extra API surface isn't worth the benefit.

Fixes bazel-contrib#2231
@alexeagle
fix(typescript): don't include _valid_options marker file in outs
6305db3 
Tested by building //packages/angular:npm_package and don't get an extra .d.ts file in the package.
Also tested the negative case by making an invalid option and check that it's still reported.

Fixes bazel-contrib#2078
@mattem @alexeagle
chore: allow node versions <= 14.14.0
0a1e576
@mattem @alexeagle
chore: update rules_docker to 0.14.4
29901c3
@evahowe
docs: minor update for readability and formatting (bazel-contrib#2243)
8db9182 
* docs: minor update for readibility and formating
@lencioni @alexeagle
Fix small typo in changelog
1672968
@alexeagle
chore(docs): move ts_library docs into ts_library
0c3bce6 
Also recommend ts_project for new uses
@alexeagle
chore(karma): remove dependency on tmp
9a50cb6
@alexeagle
feat(typescript): add allow_js support to ts_project
12571ee
@lovepocky @alexeagle
fix(exmaples/nestjs): add module_name field in ts_library
700374a
@mattem
feat: add Node v15.0.0
57d90ec 
Updates the Vue and vendored_node to Node v15.0.1 to use npm 7
@google-cla google-cla bot added the cla: yes label Nov 4, 2020
@mattem
Copy link
Collaborator Author

mattem commented Nov 4, 2020 •
edited
Loading

It seems that npm7 doesn't create the transitive node_modules folders when a dependency is referenced via file:. In the vendored_node examples test (and I guess the others), @bazel/jasmine is referenced this way, so the BUILD file generation script doesn't find all the dependencies needed on disk. In this case, we miss jasmine-reporters which is a transitive dep via @bazel/jasmine

Although... I can't find any mention of such a change in npm7.

@mattem
Copy link
Collaborator Author

mattem commented Nov 9, 2020

I filed an issue on the npm repo npm/cli#2145

@mattem mattem mentioned this pull request Nov 13, 2020
Merged
12 tasks
@alexeagle alexeagle requested a review from gregmagolan December 1, 2020 20:24
@mattem
Copy link
Collaborator Author

mattem commented Dec 8, 2020

This works correctly if the parent package.json file references a tgz file for the dependency. We could change the bazel integration tests to run the .pack target before running the test targets, or modify the pkg_npm rule to have the .pack tar as a build output (currently only available via bazel run //foo.pack

@mattem
Copy link
Collaborator Author

mattem commented Dec 8, 2020

Can make the required changes to the bazel integration tests after #2339 lands

@mattem mattem linked an issue Dec 8, 2020 that may be closed by this pull request
Upgrade our examples to npm7 #2256
Closed
@mattem
Copy link
Collaborator Author

mattem commented Dec 23, 2020

closed for #2366

@mattem mattem closed this Dec 23, 2020
@mattem mattem deleted the node15_npm7 branch December 23, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@jbedard jbedard Awaiting requested review from jbedard jbedard will be requested when the pull request is marked ready for review jbedard is a code owner

@alexeagle alexeagle Awaiting requested review from alexeagle alexeagle will be requested when the pull request is marked ready for review alexeagle is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade our examples to npm7
5 participants
@mattem @alexeagle @evahowe @lencioni @lovepocky