Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Land worker mode for rules_sass #907

Closed
alexeagle opened this issue Jul 11, 2019 · 4 comments
Closed

Land worker mode for rules_sass #907

alexeagle opened this issue Jul 11, 2019 · 4 comments
Assignees
@fenghaolw

Comments

@alexeagle
Copy link
Collaborator

Natalie would rather have an @bazel/worker npm package which provides the worker.ts code and vendor the worker_protocol.proto
@alexeagle
Copy link
Collaborator Author

See bazelbuild/bazel#3155 where we decided to just vendor a copy of the worker_protocol.proto

@fenghaolw
Copy link

bazelbuild/rules_sass#93 is the PR to rules_sass that enables worker.

This issue is a blocker since we want to make a reusable package and then we can make rules_sass to use that.

@fenghaolw
Copy link

Decision: use genrule to copy the worker.js and proto over to a new package.

Pros:

  • We still have a single source of truth
  • No need to change the release scripts

@fenghaolw
Copy link

Landed!

bazelbuild/rules_sass#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fenghaolw fenghaolw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @fenghaolw