-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed protobuf targets in Bazel #3155
Comments
These targets do exist, eg however, there's a broken reference (at least in Bazel 0.5.1)
Looks like |
Same problem prevents implementing extra actions
|
I am definitely against bundling any additional things into the bazel binary. I could maybe be convinced to add another git repo that only contains a copy of the proto (maintained by us) so that you can declare it as a workspace dep. On the other hand, I think it's also fine if you copy the proto to where you need it. |
Let me rephrase that: I'd prefer not to bundle more things into the Bazel binary. Protos are forward and backwards-compatible (as long as we only make certain kinds of changes), so it shouldn't be necessary to use exactly the same proto as Bazel is using. |
Target patterns are to be read in the name space of the main repository. This namespace, however, can also contain a mapping of repository names, in particular that of the main repository (#7130, #3155). While there, also make an error message more informative. (This message change is related as the modified evaluation order causes another error to be found first in a test example.) Change-Id: I022240e5c201d33e31f2a818f74a91af3b6f7b3d PiperOrigin-RevId: 270240453
Closing this as will not implement. |
Description of the problem / feature request / question:
For people to be able to implement workers, it would be good if targets like
@io_bazel//src/main/protobuf:worker_protocol_cc_proto
and@io_bazel//third_party/protobuf:protobuf_python
would be embedded into Bazel.Possibly as targets
@io_bazel_worker//:cc_proto
and@io_bazel_worker//:py_proto
.The text was updated successfully, but these errors were encountered: