Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add nodejs_binary cluster example #1515

Merged

Conversation

Toxicable
Copy link

@Toxicable Toxicable commented Dec 30, 2019

Adds a basic example of how to use the clustering module in Nestjs.

It currently fails with

Error: Cannot find module 'examples_nestjs/src/app.module'
Require stack:
- /SNIP/execroot/examples_nestjs/bazel-out/darwin-fastbuild/bin/src/server.sh.runfiles/examples_nestjs/src/main.js

So also doubles as a test for the linker applying correctly to nodejs_binary
When this passes then this should be resolved #227

@alexeagle
Copy link
Collaborator

You say this currently fails, but the CI is green. What is left to do before merging?

@Toxicable
Copy link
Author

Toxicable commented Jan 3, 2020

@alexeagle It fails when I run the program locally, I guess there's no test that actually starts the program up.
I was also working on a parallel PR to add some e2e test for this example but run into some issues with some random node_module files being deleted

@Toxicable
Copy link
Author

Added some testting here #1528

@alexeagle
Copy link
Collaborator

Could you rebase this please?

@Toxicable Toxicable force-pushed the examples/nodejs_binary-cluster branch from 7125ee5 to f8f3671 Compare January 9, 2020 18:30
@Toxicable Toxicable force-pushed the examples/nodejs_binary-cluster branch from f8f3671 to 8bbee23 Compare January 9, 2020 18:34
@alexeagle alexeagle merged commit f217519 into bazel-contrib:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use http cluster with bazel
3 participants