feat: bazel 4.1.0 upgrade #2995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMinar
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
|
turns out that I was pulling the wrong upstream branch (master). This has already been done in #2792 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to update to 4.1.0 a while back and failed to finish the job because it got too complicated.
I realized that others could pick up where I left and finish this, so I'm sending a PR and a bit of hope 😄 .
The main motivation is that currently rules_nodejs don't work on arm64 platform and bazel 4.1+ is needed for that. This means that anyone on Apple's M1 machines can't use bazel.
Could someone pretty please finish this so that bazel works well on M1s? thank you!