[4.x] fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows #3409
Conversation
…ode_modules on Windows (bazel-contrib#3331) * fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows * refactor(builtin): run new code path only on Windows
mistic
requested review from
mattem,
gregmagolan,
soldair and
alexeagle
as code owners
This reverts commit 8790485.
|
@alexeagle can we get this merged in? 😎 |
|
I was confused by your "Reverting those now..." comment, and whether this is ready. Can you be more clear what is the state of the 4.x branch? Are you saying it's already red at HEAD? https://buildkite.com/bazel/rules-nodejs-nodejs/builds?branch=4.x is green so something seems inconsistent. |
|
The CI job currently failing doesn't seemed to have nothing to do with that PR however you retried it a couple of times and it continued to fail. In order to validate that was not related to my changes I've commented those at 8790485, then the CI failed again at https://buildkite.com/bazel/rules-nodejs-nodejs/builds/11933 with the same errors so I was sure it was not related to the changes on this PR and to complete it I've reverted my changes to test the CI at 7fa864c. I'm not sure what changed in between the latest commit that made into I think the reasons why |
|
What I wrote above is also validated by the manual run you did at https://buildkite.com/bazel/rules-nodejs-nodejs/builds/11963 |
|
Yes, I understood that you were hitting an existing failure. I am surprised we are not running buildkite on the 4.x branch, and I had to manually trigger to discover that it's broken. |
|
#3418 to get CI green again |
…les-path-on-windows
|
Still red, that's what I expected since your PR had more tests failing than HEAD did... |
|
Alright, had the need to cherry-pick a fix for that specific test also introduced on |
… and node_modules on Windows (#3409) * fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows (#3331) * fix(runfiles): use normalized paths when guarding runfiles root and node_modules on Windows * refactor(builtin): run new code path only on Windows * chore(builtin): test ci * Revert "chore(builtin): test ci" This reverts commit 8790485. * chore(builtin): cherry-pick 8606c50 * docs(builtin): do not change unnecessary docs for this PR purpose Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
That PR is a backport of #3331 into
4.x.