Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): stray text in npm_install docs #3450

Merged

Conversation

jfirebaugh
Copy link
Contributor

"symlink_node_modules is True" doesn't make any sense in this position. I think it was a stray copy and paste from the beginning of the paragraph.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented May 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@jfirebaugh jfirebaugh force-pushed the jfirebaugh/fix-npm_install-doc branch from 0f09fbc to cfed2f3 Compare May 11, 2022 18:38
"symlink_node_modules is True" doesn't make any sense in this position. I think it was a stray copy and paste from the beginning of the paragraph.
@jfirebaugh jfirebaugh force-pushed the jfirebaugh/fix-npm_install-doc branch from cfed2f3 to 3999c95 Compare May 11, 2022 18:41
@jfirebaugh
Copy link
Contributor Author

I signed the CLA. Don't know why it's saying I didn't.

@alexeagle alexeagle merged commit 6d519eb into bazel-contrib:stable May 12, 2022
@jfirebaugh jfirebaugh deleted the jfirebaugh/fix-npm_install-doc branch May 12, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants