Teach os_name() about freebsd-amd64 #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to use `rules_nodejs` on operating systems besides Windows, Linux, and macOS, but they need to be handled in `os_name()` or else you get a `Unsupported operating system freebsd` error message. This change allows you to add a FreeBSD toolchain to your project by declaring a `nodejs_freebsd_amd64` repo with a `bin/node` executable. cockroachdb/cockroach#82762 is an example of this.
rickystewart
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to use
rules_nodejson operating systems besidesWindows, Linux, and macOS, but they need to be handled in
os_name()or else you get a
Unsupported operating system freebsderror message.This change allows you to add a FreeBSD toolchain to your project by
declaring a
nodejs_freebsd_amd64repo with abin/nodeexecutable.cockroachdb/cockroach#82762 is an example of this.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Builds on FreeBSD will fail with an "Unsupported operating system" message.
Issue Number: N/A
What is the new behavior?
Alone, this change does not make it possible to build on FreeBSD, but it does allow you to add your own toolchain that supports FreeBSD without any additional patches to
rules_nodejs.Does this PR introduce a breaking change?
Other information