fix(builtin): remove unnecessary loader script #3495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This is a reincarnation of #3493, and related to #3277.
ESM scripts couldn't be used with
nodejs_binary
when--nobazel_run_linker
was set. This is because the loader script is always a.cjs
file and fails when it tries to load an mjs entrypoint.What is the new behavior?
Remove the loader script as it no longer seems to be necessary.
Note that loading third-party dependencies in an esm script when the linker is disabled does not work as our require patch only applies to the cjs loader and not the mjs loader. However this change still provides incremental benefit as you can run an mjs script with no dependencies.
A solution that people can use to load third-party deps is to provide a custom loader using node's
--loader
option.Does this PR introduce a breaking change?