Upgrade rules_pkg to 0.3.0 to remove Python 2 dependency. #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions have `build_tar` using `python_version=PY2`, which newer versions of Bazel will no longer support. Fixes bazel-contrib#3619
rickeylev
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
|
I can't repro the CI failure, nor does it make much sense. With the Bazel CI, I see an error that looks similar (IO error downloading something else), so I'm inclined to say its a CI problem, not PR problem |
alexeagle
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions have
build_tarusingpython_version=PY2, which newerversions of Bazel will no longer support.
Fixes #3619
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 3619
What is the new behavior?
rules_pkg version 3.0 is used, which doesn't use a Python 2 binary.
Does this PR introduce a breaking change?
Other information