Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonhermeticity in oci_pull rule #108

Closed
thesayyn opened this issue Mar 17, 2023 · 1 comment · Fixed by #110
Closed

nonhermeticity in oci_pull rule #108

thesayyn opened this issue Mar 17, 2023 · 1 comment · Fixed by #110

Comments

@thesayyn
Copy link
Collaborator

I don't know why this is happening but two of the tests are failing due to changes in the upstream images
@thesayyn thesayyn changed the title non hermeticity in oci_pull rule non-hermeticity in oci_pull rule Mar 17, 2023
@thesayyn thesayyn changed the title non-hermeticity in oci_pull rule nonhermeticity in oci_pull rule Mar 17, 2023
@alexeagle
Copy link
Collaborator

I think it's hermetic, it went red when I upgraded crane, which it looks like it writes an additional mime type line in the index.json it produces. I can't explain why the PR was green though.
Trying to fix.

alexeagle added a commit that referenced this issue Mar 17, 2023
@alexeagle
chore: fix red CI
947a099 
This value seems to be written by the newer crane version when running pull

Fixes #108
@alexeagle alexeagle mentioned this issue Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix red CI bazel-contrib/rules_oci
2 participants
@alexeagle @thesayyn