Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Symlink tars instead of copying them. #508

Closed
thesayyn opened this issue Feb 21, 2024 · 1 comment · Fixed by #559
Closed

FR: Symlink tars instead of copying them. #508

thesayyn opened this issue Feb 21, 2024 · 1 comment · Fixed by #559
Labels
enhancement New feature or request performance
Milestone
2.0

Comments

@thesayyn
Copy link
Collaborator

Currently, we copy them which takes long time for big files. Technically it's possible to symlink them into the output which should be instantaneous.

This wasn't possible before due to a limitation is Bazel. with bazelbuild/bazel#21263 is fixed, it possible to do this now.
@thesayyn thesayyn added enhancement New feature or request performance labels Feb 21, 2024
@thesayyn thesayyn added this to the 2.0 Performance Redesign milestone Feb 25, 2024
@thesayyn thesayyn mentioned this issue Apr 10, 2024
Closed
@thesayyn thesayyn mentioned this issue May 7, 2024
Merged
@thesayyn
Copy link
Collaborator Author

thesayyn commented May 8, 2024

fixed by #559

@thesayyn thesayyn closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

feat: implement tars symlinks bazel-contrib/rules_oci
1 participant
@thesayyn