refactor: allow relative symlinks that points out of the treeartifact #21263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Rules-API
tjgq
requested changes
Feb 9, 2024
src/test/java/com/google/devtools/build/lib/skyframe/TreeArtifactValueTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/skyframe/TreeArtifactBuildTest.java
Outdated
Show resolved
Hide resolved
tjgq
added
awaiting-user-response
|
df07d27 touched some code around this area, so you'll have to rebase your PR. |
|
All right. I'll get to it soon hopefully. |
thesayyn
force-pushed
the
tree_artifact_symlinks
branch
from
4622cb1
to
dde13d9
Compare
|
@tjgq dangling symlinks isn't seem to be supported anymore. is that expected? i get tests failing with "is a dangling symbolic link" |
|
Also would it be possible to cherry pick this into 7.1.0? We'd like to start rolling this out with rules_oci as soon as we can. |
|
@tjgq Ready for another pass. |
tjgq
approved these changes
Feb 20, 2024
|
@bazel-io fork 7.1.0 |
thesayyn
added a commit
to thesayyn/bazel_features
that referenced
this pull request
Feb 20, 2024
A feature gate for bazelbuild/bazel#21263
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 21, 2024
…not point outside the tree. As discussed in bazelbuild#20891, the restriction is pointless, as it can already be bypassed with an absolute symlink. Note that the symlinks are still required not to dangle in all cases. Also rename and reorganize the tests in TreeArtifactBuildTest in a more logical manner. Fixes bazelbuild#20891. Closes bazelbuild#21263. PiperOrigin-RevId: 608926604 Change-Id: I967a383b9891360700f868abd5c2d292e0e7974e
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
…act may not point outside the tree. (#21449) As discussed in #20891, the restriction is pointless, as it can already be bypassed with an absolute symlink. Note that the symlinks are still required not to dangle in all cases. Also rename and reorganize the tests in TreeArtifactBuildTest in a more logical manner. Fixes #20891. Closes #21263. Commit 5506a0f PiperOrigin-RevId: 608926604 Change-Id: I967a383b9891360700f868abd5c2d292e0e7974e Co-authored-by: thesayyn <thesayyn@gmail.com>
meteorcloudy
pushed a commit
to bazel-contrib/bazel_features
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20891