Set PATH_PREFIX=./ instead of failing to bazel run a program with a perl_binary data dep
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalten
changed the title
PATH_PREFIX=./ instead of failingPATH_PREFIX=./ instead of failing to bazel run a program with a perl_binary data dep
lalten
force-pushed
the
fix-path-prefix-for-bazel-run-data-dep
branch
from
0b29c4d to
dd80f71
Compare
lalten
added a commit
to lalten/bazel-central-registry
that referenced
this pull request
Aug 18, 2024
Wyverald
pushed a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Aug 19, 2024
This is latest rules_perl plus * bazel-contrib/rules_perl#62 * bazel-contrib/rules_perl#65 * bazel-contrib/rules_perl#66 Obviously it would be nice to get a review / merge this upstream. If that still happens we can add a new (0.2.4 ?) release without patches in the BCR. The patch enables external rules_perl Bazel repos to work under Bzlmod. This is needed for https://github.com/lalten/rules_cpan to work out of the box needs the `unstable source url` label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the issue that the binary wrapper fails when it is a data dependency of some other program which is run under
bazel run(it does work underbazel test!)The issue is that during bazel run RUNFILES_DIR may not be set and the MANIFEST file may not exist at ../.. even if you did not cd somewhere else.
The correct thing to do for the wrapper in this case is to accept the interpreter short path and main short path as-is from the starlark side. We can just set PATH_PREFIX=./ for the same effect.
I added a test that is red without the binary_wrapper change and becomes green when the change is applied. The trick here is to use
env -ito remove the test envs from the sh_test so it behaves more like a bazel run and not bazel test.Note that I don't think the binary_wrapper should explicitly fail anyways. Rather it should just let things play out. Other things will fail in any case if paths are not set up correctly. And if things won't fail -- well then the wrapper shouldn't make them fail either :)