Upgrade testing platforms #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@skeletonkey Can you take a look at the failing test? Also failing in postsubmit. |
|
I will take a look at this tomorrow. |
added 6 commits
September 22, 2024 15:56
IO::Tty is problematic on Mac. There should be an easier example to replace it with.
I will create a todo to figure out what is going on with this test and ask the original author to take a look.
The script does not run on Mac. Need to revisit its purpose and work out how to get it to run on all environments.
|
@meteorcloudy I took the following steps to get this build to pass:
This branch should be ready to merge. |
skeletonkey
approved these changes
Sep 22, 2024
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also testing presubmit after repo transfer