version 1.6.0+ with experimental_index_url are fetching incorrect wheels for glibc version

[scasagrande]

🐞 bug report

Affected Rule

The issue is caused by the rule: rules_python 1.6.0+ when using experimental_index_url

Is this a regression?

Yes, the previous version in which this bug was not present was: 1.5.4

Description

When using rules_python 1.6.0 or 1.6.1 and the experimental_index_url feature, incorrect wheels are fetched for the glibc version on the system. For example, systems with glibc 2.28 are attempting to download and execute manylinux_2_34 wheels instead of manylinux_2_28 ones.

🔬 Minimal Reproduction

https://github.com/scasagrande/rules-python-glibc-issue

🔥 Exception or Error

See repro README

🌍 Your Environment

Operating System:

I specifically tested on Rocky 8

Output of bazel version:

Seen on both 8.3.1 and 8.4.0, but is likely independent of bazel version

Rules_python version:

1.6.0 and 1.6.1 are both exhibiting this behaviour.

[scasagrande]

related to #3058 ?

[scasagrande]

oh I see that #3058 introduced pip.default https://rules-python.readthedocs.io/en/latest/api/rules_python/python/extensions/pip.html#pip.default

and I guess that by default it doesn't restrict on manylinux glibc version?

[scasagrande]

adding

pip.default(
    config_settings = [
        "@platforms//os:linux",
    ],
    platform = "linux_x86_64",
    whl_platform_tags = ["manylinux_2_28"],
)

Results in a pass. Does this need to be specified separately for both linux x86 and aarch64?

[aignas]

Ah, the breakage was unintentional (I think previously we had different behaviour - select the lowest available version by default), but you've found the toggles to switch to customize things, for a good example see MODULE.bazel of rules_python itself.

The logic in

rules_python/python/private/pypi/select_whl.bzl

Line 84 in 9ba8c12

keys.append((priority, version))

needs to be adjust to pick the lowest libc version whl if we don't specify the version explicitly.

PRs to fix this are welcome.

[aignas]

OK, I was nerd sniped and the fix was fast.

[scasagrande]

Ha! I was just looking into it and it looks like I narrowed it down to the same spot as you.