fix: Don't fail in override from a non-root module #2566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mailto-jonas
requested review from
aignas,
groodt and
rickeylev
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This patch enable calls to pypi override from a non-root module without failing. The call will instead be silently ignored. Fixes bazel-contrib#2550
mailto-jonas
force-pushed
the
ignore_pypi_override_for_non_root
branch
from
f147bf1 to
0661565
Compare
aignas
approved these changes
Jan 21, 2025
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Jan 21, 2025
This patch enable calls to pypi override from a non-root module without failing. The call will instead be silently ignored. Fixes bazel-contrib#2550 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Jan 21, 2025
This patch enable calls to pypi override from a non-root module without failing. The call will instead be silently ignored. Fixes bazel-contrib#2550 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> fix(toolchain) Override coverage rc
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Jan 21, 2025
This patch enable calls to pypi override from a non-root module without failing. The call will instead be silently ignored. Fixes bazel-contrib#2550 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> fix(toolchain) Override coverage rc
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Jan 21, 2025
This patch enable calls to pypi override from a non-root module without failing. The call will instead be silently ignored. Fixes bazel-contrib#2550 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Jan 21, 2025
This patch enable calls to pypi override from a non-root module without failing. The call will instead be silently ignored. Fixes bazel-contrib#2550 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com> fix(toolchain) Override coverage rc
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Jan 21, 2025
This patch enable calls to pypi override from a non-root module without failing. The call will instead be silently ignored. Fixes bazel-contrib#2550 --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enable calls to pypi override from a non-root module without failing. The call will instead be silently ignored.
Fixes #2550