feat(gazelle): Gazelle resolves module-level imports of py_proto_library
#3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts generated for it
shaldengeki
requested review from
dougthor42,
aignas and
rickeylev
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1703. (I think this is only asking for module-level imports.)
This adds support in Gazelle for resolving module-level imports of
py_proto_libraryrules. Note that this does not support:See the tests for examples of how this works. I would ideally like to implement the first one as well, but I think the "right" way to do that is to use something that's only present in Gazelle 0.38. So that'll have to wait on an upgrade of Gazelle in this repo; in the meanwhile, I think this is worth landing.