Skip to content

fix(core): do not assume rules_python runtime #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025
Merged

fix(core): do not assume rules_python runtime #3134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc2d3c2
fix(core): do not assume rules_python runtime
aignas Aug 3, 2025
a4476c0
use regular markdown url for issue ref
rickeylev Aug 11, 2025
9d25e1f
Merge branch 'main' into fix.py_runtime.missing_attrs
rickeylev Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ END_UNRELEASED_TEMPLATE
* (toolchains) use "command -v" to find interpreter in `$PATH`
([#3150](https://github.com/bazel-contrib/rules_python/pull/3150)).
* (pypi) `bazel vendor` now works in `bzlmod` ({gh-issue}`3079`).
* (core) builds work again on `7.x` `WORKSPACE` configurations
([#3119](https://github.com/bazel-contrib/rules_python/issues/3119)).

{#v0-0-0-added}
### Added
Expand Down
8 changes: 6 additions & 2 deletions python/private/py_executable.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,7 @@ def _create_stage1_bootstrap(
is_for_zip,
runtime_details,
venv = None):
"""Create a legacy bootstrap script that is written in Python."""
runtime = runtime_details.effective_runtime

if venv:
Expand All @@ -805,8 +806,11 @@ def _create_stage1_bootstrap(

python_binary_actual = venv.interpreter_actual_path if venv else ""

# Runtime may be None on Windows due to the --python_path flag.
if runtime and runtime.supports_build_time_venv:
# Guard against the following:
# * Runtime may be None on Windows due to the --python_path flag.
# * Runtime may not have 'supports_build_time_venv' if a really old version is autoloaded
# on bazel 7.6.x.
if runtime and getattr(runtime, "supports_build_time_venv", False):
resolve_python_binary_at_runtime = "0"
else:
resolve_python_binary_at_runtime = "1"
Expand Down