Skip to content

fix: backport #3048 to 1.4: don't watch non-existent include directory #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025
Merged

fix: backport #3048 to 1.4: don't watch non-existent include directory #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2687664
fix(local-toolchains): don't watch non-existent include directory (#3…
rickeylev Jul 4, 2025
da8098a
rm changelog deltas
honglooker Aug 13, 2025
8acdb82
one more changelog tweak
honglooker Aug 13, 2025
a20097f
add 1.4.2 changelog
honglooker Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ END_UNRELEASED_TEMPLATE
-->


{#1-4-2}
## [1.4.2] - 2025-08-13

[1.4.2]: https://github.com/bazel-contrib/rules_python/releases/tag/1.4.2

### Fixed
* (toolchains) `local_runtime_repo` now checks if the include directory exists
before attempting to watch it, fixing issues on macOS with system Python
([#3043](https://github.com/bazel-contrib/rules_python/issues/3043)).


{#1-4-1}
## [1.4.1] - 2025-05-08

Expand Down
10 changes: 9 additions & 1 deletion python/private/local_runtime_repo.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,15 @@ def _local_runtime_repo_impl(rctx):
logger.info(lambda: _format_get_info_result(info))

# NOTE: Keep in sync with recursive glob in define_local_runtime_toolchain_impl
repo_utils.watch_tree(rctx, rctx.path(info["include"]))
include_path = rctx.path(info["include"])

# The reported include path may not exist, and watching a non-existant
# path is an error. Silently skip, since includes are only necessary
# if C extensions are built.
if include_path.exists and include_path.is_dir:
repo_utils.watch_tree(rctx, include_path)
else:
pass

# The cc_library.includes values have to be non-absolute paths, otherwise
# the toolchain will give an error. Work around this error by making them
Expand Down