fix: properly locate OS-installed system Ruby
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #125 Updates the method for determining the system Ruby path in `ruby/private/download.bzl`. - Replaces the use of `repository_ctx.which("ruby")` with `repository_ctx.execute(["ruby", "-e", "puts RbConfig.ruby"])` to accurately determine the Ruby binary path when using the system Ruby. - Implements error handling for the command execution, failing the build with a clear message if the system Ruby path cannot be determined. - Maintains the symlink creation logic to link the determined Ruby directory to `dist/bin`, ensuring compatibility with existing setups. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/bazel-contrib/rules_ruby/issues/125?shareId=82c03088-9c65-4564-af8b-4c7aec83de72).
p0deje
changed the title
system Ruby
p0deje
changed the title
system Rubysystem Ruby
sushain97
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #125
Updates the method for determining the system Ruby path in
ruby/private/download.bzl.repository_ctx.which("ruby")withrepository_ctx.execute(["ruby", "-e", "puts RbConfig.ruby"])to accurately determine the Ruby binary path when using the system Ruby.dist/bin, ensuring compatibility with existing setups.For more details, open the Copilot Workspace session.