add --disable-install-doc to Ruby configure args to speed up installation time
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I will merge as soon as CI passes. Ideally, we should just download a prebuilt toolchain, but it's not possible at the moment as there are no such binaries. |
Yeah, agree. It's hard without Ruby themselves providing a truly portable distribution. |
|
@p0deje 👋 Just wanted to bump this one if you feel it's good to merge! 🙏 |
p0deje
approved these changes
Jun 19, 2024
Sorry, I started CI but then never followed up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I was looking at possible opportunities to speed up Ruby build time and this one seemed like a good candidate. I was able to shave off about 30 seconds by adding this flag to not compile docs material.
On my M3 Max laptop, installing Ruby 3.3.2 with current
main:With this change:
Another more extensible approach could be to make this part of a configurable
configurearg setting passed into the rules' toolchain config. But I thought perhaps this is just a good start to add this as a way to speed up the rules fetch in general, and I couldn't really think of a reason someone would want doc generation for the core Ruby itself in the context of a Bazel build.