Skip to content

Conversation

@WojciechMazur
Copy link
Collaborator

Removes unused imports from dependency_analyzer - these would warn when building in user projects

Copy link
Collaborator

@mbland mbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbland
Copy link
Collaborator

mbland commented Oct 20, 2025

Interesting side note that I just noticed: BuildKite appears to build the PR branch without merging it into the current head of 'master' first (like GitHub Actions does). This would be why the last_green build still fails, even though it started after I'd merged #1778.

@WojciechMazur WojciechMazur merged commit 7be0d3f into bazel-contrib:master Oct 20, 2025
1 check passed
@WojciechMazur WojciechMazur deleted the cleanup/dependency_analyzer_unused_defs branch October 20, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants