Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document how to use a distinct output base #367

Merged

Conversation

cameron-martin
Copy link
Collaborator

This flips the bazel.queriesShareServer default back to true, since I think it was a bit hasty in #355 to break everyone not on the latest bazel version. Instead, I have added a section to the docs, linked from the setting, describing how to safely disable this option.

Copy link
Collaborator

@vogelsgesang vogelsgesang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

Two smaller nits, feel free to ignore them if you disagree

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@cameron-martin
Copy link
Collaborator Author

@vogelsgesang Looks like the email of yours that GitHub used when I clicked "commit suggestion" hasn't signed the CLA.

This flips the `bazel.queriesShareServer` default back to `true`, since I think it was a bit hasty in bazel-contrib#355 to break everyone not on the latest bazel version. Instead, I have added a section to the docs, linked from the setting, describing how to safely disable this option.
@vogelsgesang
Copy link
Collaborator

Thanks for the heads-up! Interesting that Github uses another one of my email addresses for commit suggestions... I will have to figure out how to change that...

@cameron-martin cameron-martin enabled auto-merge (squash) April 8, 2024 15:31
@cameron-martin cameron-martin merged commit 14ed3ea into bazel-contrib:master Apr 8, 2024
4 checks passed
@cameron-martin cameron-martin mentioned this pull request Apr 8, 2024
@cameron-martin cameron-martin deleted the distinct-output-base branch July 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants