Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Link the full label / file name instead of individual components #382

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: Link the full label / file name instead of individual components #382

merged 2 commits into from
Apr 16, 2024

Commits on Apr 16, 2024

  1. fix: Link the full label / file name instead of linking each componen… 

    …t individually

So far, the `go_to_definition` provider did not provide a
`originSelectionRange`. Hence, VS Code was falling back on its internal
tokenization to decide which part of the text to provide the HyperLink
for.

For the label "my/package:file.txt", we hence linked `my`, `package`,
`file` and `txt` individually, all pointing to the same file.

With this change, we now instead always provide the link on the full
label.
    @vogelsgesang
    vogelsgesang committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    527f2d3 View commit details
    Browse the repository at this point in the history

  2. Remove unused Location

    @vogelsgesang
    vogelsgesang committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    dbb7ad9 View commit details
    Browse the repository at this point in the history