fix(codelens): Apply commandArgs to run targets #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makestuff
requested review from
coeuvre,
jfirebaugh,
cameron-martin and
vogelsgesang
as code owners
vogelsgesang
changed the title
vogelsgesang
approved these changes
Jul 20, 2024
makestuff
force-pushed
the
commandargs-for-run
branch
2 times, most recently
from
073a29b
to
cc5fe51
Compare
makestuff
force-pushed
the
commandargs-for-run
branch
from
cc5fe51
to
54d0aae
Compare
cameron-martin
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, commandArgs is only applied to debug, test and coverage targets, not run targets, which is inconsistent: clicking a "build" codelens for a component and then clicking a "run" codelens for a runnable target which depends on that component ends up rebuilding it with a different configuration (e.g debug/optimized, remote/local build). It would be much more consistent if commandArgs applied to run targets.
This fixes #394.