Skip to content

Commit

Permalink
Merge pull request #79 from bazel-ios/amber/rename-indexstore-dir
Browse files Browse the repository at this point in the history
Separate objective-c indexstore units and records by objc_library
  • Loading branch information
amberdixon authored Jun 25, 2020
2 parents d81b490 + f88a3cf commit 3892255
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
run: |
set -euo pipefail
bazelisk query 'kind(xcodeproj, tests/macos/xcodeproj/...)' | xargs -n 1 bazelisk run
bazel query 'attr(executable, 1, kind(genrule, tests/macos/xcodeproj/...))' | xargs -n 1 bazelisk run
bazelisk query 'attr(executable, 1, kind(genrule, tests/macos/xcodeproj/...))' | xargs -n 1 bazelisk run
git diff --exit-code tests/macos/xcodeproj
- name: Run Xcode builds
run: ./tests/macos/xcodeproj/build.sh
Expand Down
5 changes: 4 additions & 1 deletion rules/library.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,10 @@ def apple_library(name, library_tools = {}, export_private_headers = True, names

objc_copts.append("-I.")

objc_copts.extend(("-index-store-path", "$(GENDIR)/rules_ios_apple_library_objc.indexstore"))
objc_copts.extend(("-index-store-path", "$(GENDIR)/{package}/rules_ios_objc_library_{libname}.indexstore".format(
package = native.package_name(),
libname = objc_libname,
)))
objc_library(
name = objc_libname,
srcs = objc_sources + objc_private_hdrs + objc_non_exported_hdrs,
Expand Down
4 changes: 2 additions & 2 deletions tests/macos/xcodeproj/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ cat <<'EOS' > $@
#!/bin/sh
set -euxo pipefail
rm -fr {package_name}/{target_name}.xcodeproj
bazel run {package_name}:{target_name}
bazel run {package_name}:{target_name}
bazelisk run {package_name}:{target_name}
bazelisk run {package_name}:{target_name}
EOS
""".format(
package_name = package_name(),
Expand Down

0 comments on commit 3892255

Please sign in to comment.