Bump rules_apple to pick up smartcard identities support #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jerrymarino ERROR: Traceback (most recent call last):
File "/private/var/tmp/_bazel_runner/c2342bca25695567c8c3f3be166b56b3/external/build_bazel_rules_apple/apple/internal/apple_framework_import.bzl", line 62, column 6, in <toplevel>
"swift_clang_module_aspect",
Error: file '@build_bazel_rules_swift//swift:swift.bzl' does not contain symbol 'swift_clang_module_aspect' |
|
@thiagohmcruz Yep it looks like we'll need to rebase our rules_swift fork again. I've been thinking about simplifying the dependency altogether, but I think I've got a compromise that will let us drop the fork: #251 - Let's sync up offline about it |
|
@thiagohmcruz The rules_swift PR has landed this morning - so we can fix the issue you're hitting by rebasing rules_ios once #246 lands |
Awesome, thx @jerrymarino! That PR LGTM |
thiagohmcruz
force-pushed
the
thiago/smartcard-identitites
branch
from
cd1eab8 to
35f2a76
Compare
segiddins
approved these changes
Jun 9, 2021
thiagohmcruz
force-pushed
the
thiago/smartcard-identitites
branch
from
35f2a76 to
b2d9b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To pick up bazelbuild/rules_apple#1181