Handle toolchain provider renames from rules_apple
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary `resources_partial` has renamed `apple_toolchain_info` to `apple_mac_toolchain_info`: https://github.com/bazelbuild/rules_apple/blob/56c54f25253b616bdd852b569023a437a4f95768/apple/internal/partials/resources.bzl#L558 `AppleSupportToolchainInfo` provider has been renamed to `AppleSupportMacToolsToolchainInfo` (and then to `AppleMacToolsToolchainInfo`): bazelbuild/rules_apple@eba6e68#diff-f06c6d6866f9332aa9ea85f2e0ccc46f67dfa8e67814a57f243bad6441856f4eL260-R260 bazelbuild/rules_apple@25ae977#diff-fbbb4cbee7c788f8869825280431690c3a1f7994af24a89ab86a17ca72a140c9R17 `xcode_path_wrapper` was removed from `apple_support.run()`: bazelbuild/rules_apple@c9d6a57#diff-6c787cdc6f35c8d92b621a6469457c92f97d29e4a4005ee6617fb2851725b0f4L81
|
Nice I did the same here already: #493 |
|
Closing in favor of #493. Thanks for the heads up, @luispadron! |
|
@mattrobmattrob although it looks like I changed more 🤔 |
|
I'd bet yours is a more future-proof forward of things into the partials. 👍 |
mattrobmattrob
deleted the
mr/handle.toolchain.provider.renames.from.rules_apple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This bumps
rules_appleto a non-tagged release so please block if that's not desired.Summary
resources_partialhas renamedapple_toolchain_infotoapple_mac_toolchain_info:https://github.com/bazelbuild/rules_apple/blob/56c54f25253b616bdd852b569023a437a4f95768/apple/internal/partials/resources.bzl#L558
AppleSupportToolchainInfoprovider has been renamed toAppleSupportMacToolsToolchainInfo(and then toAppleMacToolsToolchainInfo):bazelbuild/rules_apple@eba6e68#diff-f06c6d6866f9332aa9ea85f2e0ccc46f67dfa8e67814a57f243bad6441856f4eL260-R260
bazelbuild/rules_apple@25ae977#diff-fbbb4cbee7c788f8869825280431690c3a1f7994af24a89ab86a17ca72a140c9R17
xcode_path_wrapperwas removed fromapple_support.run():bazelbuild/rules_apple@c9d6a57#diff-6c787cdc6f35c8d92b621a6469457c92f97d29e4a4005ee6617fb2851725b0f4L81