Add toolchains to rules that use @bazel_tools//tools/cpp:toolchain_type
#807
Conversation
…_type` Signed-off-by: Matt Robinson <mattrob@hey.com>
mattrobmattrob
requested review from
luispadron and
thiagohmcruz
and removed request for
luispadron
| @@ -1191,6 +1191,7 @@ def _apple_framework_packaging_impl(ctx): | |||
|
|
|||
| apple_framework_packaging = rule( | |||
| implementation = _apple_framework_packaging_impl, | |||
| toolchains = ["@bazel_tools//tools/cpp:toolchain_type"], | |||
There was a problem hiding this comment.
Any downsides or fallout from adding this? I wondered if we need to add it to other rules; hmap, middlemen, etc
There was a problem hiding this comment.
I don't know of any. But I still haven't narrowed down the reasons for 👇 when using Bazel 7 with this change (like in #797):
clang: error: using sysroot for 'AppleTVSimulator' but targeting 'MacOSX' [-Werror,-Wincompatible-sysroot]
There was a problem hiding this comment.
Unrelated but should we delete this file in a follow-up, it appears to be unused.
There was a problem hiding this comment.
I wonder if this has to do with the move to apple_support toolchain
The Apple CC toolchain in this repository provides toolchains for building for Apple platforms besides macOS. Since Bazel 7 this toolchain is required when targeting those platforms but the toolchain also supports Bazel 6.
https://github.com/bazelbuild/apple_support#toolchain-setup
|
Given the discussion in https://bazelbuild.slack.com/archives/CD3QY5C2X/p1701890904270059, I'm less worried about the |
Fix the following from #795: