Update CI for latest actions and to use matrix #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/update-ci
branch
10 times, most recently
from
18fdc13 to
4b4ef84
Compare
luispadron
commented
Mar 4, 2024
| @@ -52,9 +52,6 @@ build:ios_multi_arch_test --ios_minimum_os=10.2 | |||
| # to exemplify fat binaries on the latest version | |||
| build:ios_multi_arch_test --ios_multi_cpus=x86_64 | |||
|
|
|||
| # - Remote cache configuration | |||
| build:ci_with_caches --config=ci --config=remote_cache | |||
There was a problem hiding this comment.
This config was previously used by all jobs, seemed redundant to define another ci config so just using ci with --remote_cache by default now
luispadron
force-pushed
the
luis/update-ci
branch
from
4b4ef84 to
b0b6495
Compare
luispadron
force-pushed
the
luis/update-ci
branch
from
b0b6495 to
a4e83a3
Compare
|
If this is approved i'll update the required jobs to use these new ones in the settings |
thiagohmcruz
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates GitHub CI to make it easier to add more Bazel/Xcode Versions.
Changes:
checkoutandupload-artifactsactions tov4, this fixes warnings we get on every PR for deprecated Node versionsmatrixstrategy for all jobs, this adds abazel_versionandxcode_versionwhich each job will be configured to run against. We can add Bazel 7 once Add support for Bazel 7 #795 is done.--config=vfsand non-vfs job, this can be set with a custom matrix without duplicating the job code.--remote-cacheflag, this was set by every job already.Example: