Bazel 7: Set framework_includes in import_middleman #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohmcruz
force-pushed
the
thiago/import_middleman-cc_info-framework_includes
branch
from
847894a
to
dda42d2
Compare
luispadron
approved these changes
Jun 14, 2024
mattrobmattrob
approved these changes
Jun 14, 2024
|
Is it easy to add a test that demonstrates this failure on th Bazel 7.X test jobs? |
@mattrobmattrob not sure but I'll take all look |
|
@mattrobmattrob just FYI I'll add a test to this in a follow up. Couldn't find an easy way to repro what I see inside yet. |
thiagohmcruz
deleted the
thiago/import_middleman-cc_info-framework_includes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of: #873
While testing Bazel 7 hit some build failures due to missing
-Fflags in the invocation.I could set other attributes here too but since I'm not super familiar with this rule I'd rather add what is missing progressively as I run tests in Bazel 7.