Skip to content

Commit

Permalink
Revert "Stop setting -DNS_BLOCK_ASSERTIONS=1 for :release (#194)
Browse files Browse the repository at this point in the history
This reverts commit 599a84c.

This was the right long-term decision, but it's caused some regressions
for build environments that expected this to be set due to customized
cc_toolchains, so let's revert it for now.
  • Loading branch information
jparise authored Sep 23, 2021
1 parent 9aefce7 commit ad1dec4
Show file tree
Hide file tree
Showing 64 changed files with 404 additions and 202 deletions.
15 changes: 10 additions & 5 deletions IntegrationTests/GoldMaster/Adjust.podspec.json.goldmaster

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 8 additions & 4 deletions IntegrationTests/GoldMaster/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ objc_library(
"-DPOD_CONFIGURATION_DEBUG=1"
],
":release": [
"-DPOD_CONFIGURATION_RELEASE=1"
"-DPOD_CONFIGURATION_RELEASE=1",
"-DNS_BLOCK_ASSERTIONS=1"
]
}
) + [
Expand Down Expand Up @@ -277,7 +278,8 @@ objc_library(
"-DPOD_CONFIGURATION_DEBUG=1"
],
":release": [
"-DPOD_CONFIGURATION_RELEASE=1"
"-DPOD_CONFIGURATION_RELEASE=1",
"-DNS_BLOCK_ASSERTIONS=1"
]
}
) + [
Expand Down Expand Up @@ -1534,7 +1536,8 @@ objc_library(
"-DPOD_CONFIGURATION_DEBUG=1"
],
":release": [
"-DPOD_CONFIGURATION_RELEASE=1"
"-DPOD_CONFIGURATION_RELEASE=1",
"-DNS_BLOCK_ASSERTIONS=1"
]
}
) + [
Expand Down Expand Up @@ -2945,7 +2948,8 @@ objc_library(
"-DPOD_CONFIGURATION_DEBUG=1"
],
":release": [
"-DPOD_CONFIGURATION_RELEASE=1"
"-DPOD_CONFIGURATION_RELEASE=1",
"-DNS_BLOCK_ASSERTIONS=1"
]
}
) + [
Expand Down
9 changes: 6 additions & 3 deletions IntegrationTests/GoldMaster/Bolts.podspec.json.goldmaster

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 26 additions & 13 deletions IntegrationTests/GoldMaster/Braintree.podspec.json.goldmaster

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions IntegrationTests/GoldMaster/Branch.podspec.json.goldmaster

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions IntegrationTests/GoldMaster/Calabash.podspec.json.goldmaster

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion IntegrationTests/GoldMaster/CardIO.podspec.json.goldmaster

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion IntegrationTests/GoldMaster/EarlGrey.podspec.json.goldmaster

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ad1dec4

Please sign in to comment.