forked from boostorg/outcome
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from boostorg:master #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king change if you define your own status code domains.
…ypes for improved compatibility with third party software such as [ASIO](https://think-async.com/Asio/).
…_outcome` types whose `EC` is a `status_code`. Erased status codes are move-only which makes the Result/Outcome type move-only, but they provide a cloning function, so this convenience function both clones the status code and propagates the spare storage so stack backtraces etc are also cloned. - Add type constraints to `success()` and `failure()` to disable them if they aren't available.
…gets an ICE from `gimplify_expr` in any `OUTCOME_CO_TRY` taking even a mildly complex expression, which obviously is a showstopper. The work around assigns the failure type to a stack temporary before `co_return`-ing that temporary. Thanks to RVO pre-17 and copy elision since, this should add no runtime overhead.
Merge branch 'develop'
- To Experimental.Outcome add `clone()` for `basic_result` and `basic_outcome` types whose `EC` is a `status_code`. Erased status codes are move-only which makes the Result/Outcome type move-only, but they provide a cloning function, so this convenience function both clones the status code and propagates the spare storage so stack backtraces etc are also cloned. - Add type constraints to `success()` and `failure()` to disable them if they aren't available.
Work around a bug in GCC's C++ Coroutines implementation whereby one gets an ICE from `gimplify_expr` in any `OUTCOME_CO_TRY` taking even a mildly complex expression, which obviously is a showstopper. The work around assigns the failure type to a stack temporary before `co_return`-ing that temporary. Thanks to RVO pre-17 and copy elision since, this should add no runtime overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )