support selectively disabling NS_BLOCK_ASSERTIONS for opt builds #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsky
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
approved these changes
Aug 12, 2024
luispadron
approved these changes
Aug 12, 2024
|
previously this was always enabled, for dbg/fastbuild/opt, now it looks like it's only enabled for opt? i think tests would be nice to cover the behavior here |
|
@keith From what I can tell, that isn't the case. My understanding is that I am willing to write tests, but was having trouble finding any existing clang flag tests. Reusing the bits for linker tests wasn't working for me. Do you know where I could find them? |
|
oh you're right, the constraint was folded below more lines than i expected. here's a file you can add tests in #342 |
aaronsky
force-pushed
the
aaronsky/ns_block_assertions_feature
branch
from
588a3b6 to
88153a1
Compare
brentleyjones
approved these changes
Aug 12, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maintains the default behavior of passing
-DNS_BLOCK_ASSERTIONS=1for opt builds. for builds where this is undesirable, set--features=-ns_block_assertionsto unconditionally not-set this flag, without having to unset the entiredefault_compile_flagsfeature.does not add tests, but i can add them if requested.