Use -Xlinker for -install_name

[fmeum]

This supports , in runtime_solib_name.

[fmeum]

Would it be possible to get a release after this has been merged? This would unblock enabling C++ remote execution tests for macOS in Bazel (bazelbuild/bazel#23085). The PR currently patches in this change, but I'm not sure whether it will be considered mergeable in this state.

[keith]

when do these paths have commas? in general we preferred the comma version because bazel was doing weirdo stuff like uniquing linkopts and therefore dropping the -Xlinker arg, i think this is probably an obsolete specific concern, but that was the general idea

[fmeum]

Target names with commas can trigger this (there's a Bazel test for this case). The feature above this one already uses -Xlinker. If deduplication doesn't work, that sounds like a bug we should solve regardless.

[keith]

fwiw we tried to fix that but weren't able to land a pr upstream

[fmeum]

Can you point me to the PR?

[keith]

see the deduplication stuff in this issue bazelbuild/bazel#16939 (comment)