Remove passing lists of args to genrule #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
commented
Oct 30, 2020
| @@ -446,16 +446,6 @@ def _run_shell( | |||
| actions = actions, | |||
| ) | |||
|
|
|||
| # TODO(b/77637734) remove "workaround" once the bazel issue is resolved. | |||
There was a problem hiding this comment.
I don't have insight into if this is closed yet
keith
referenced
this pull request
in bazelbuild/rules_apple
Oct 30, 2020
incompatiblity with Bazel at HEAD. Disable this for now because apple_support currently relies on a workaround that needs to be able to pass a sequence of strings to actions.run_shell's 'command'.
segiddins
reviewed
Oct 30, 2020
| @@ -80,7 +80,7 @@ def _apple_genrule_impl(ctx): | |||
| inputs = resolved_srcs.to_list() + resolved_inputs, | |||
| outputs = files_to_build.to_list(), | |||
| env = ctx.configuration.default_shell_env, | |||
| command = argv, | |||
| command = " ".join(argv), | |||
There was a problem hiding this comment.
should we use the shell escape method in skylib here? https://github.com/bazelbuild/bazel-skylib/blob/182046f090d6ecae264c7e5d520da096370287e2/lib/shell.bzl#L37-L49
This is required for this migration bazelbuild/bazel#5903
keith
force-pushed
the
ks/remove-passing-lists-of-args-to-genrule
branch
from
066a737
to
b7047fa
Compare
brentleyjones
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for this migration bazelbuild/bazel#5903