feat: add boost.detail #2580

wep21 · 2024-08-10T14:08:14Z

add boost.detail
need skip url stability check

bazel-io · 2024-08-10T14:08:33Z

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.detail) have been updated in this PR. Please review the changes.

Vertexwahn · 2024-08-10T20:51:27Z

@fmeum @wep21 For me it seems that the BCR validation has some issue. Maybe module_file.readlink().as_posix() needs to be replaced with module_file.resolve().as_posix() - not 100% sure... - on my local machine the BCR validation works without the error reported on CI

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

Require module maintainers' approval for newly pushed changes.

modules/boost.detail/1.83.0/MODULE.bazel

modules/boost.detail/1.83.0/presubmit.yml

modules/boost.detail/1.83.0/overlay/BUILD.bazel

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 · 2024-08-12T04:40:31Z

@Vertexwahn @fmeum I have encountered 2 problems.

I cannot build targets with --process_headers_in_dependencies

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from include/boost/detail/utf8_codecvt_facet.ipp:13:
include/boost/detail/utf8_codecvt_facet.hpp:99:1: error: unknown type name 'BOOST_UTF8_BEGIN_NAMESPACE'
BOOST_UTF8_BEGIN_NAMESPACE
^
include/boost/detail/utf8_codecvt_facet.hpp:218:1: error: unknown type name 'BOOST_UTF8_END_NAMESPACE'
BOOST_UTF8_END_NAMESPACE
^
In file included from include/boost/detail/utf8_codecvt_facet.ipp:16:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/cassert:24:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:81:1: error: expected unqualified-id
__BEGIN_DECLS
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:71:32: note: expanded from macro '__BEGIN_DECLS'
#define __BEGIN_DECLS   extern "C" {
                               ^
include/boost/detail/utf8_codecvt_facet.ipp:28:1: error: unknown type name 'BOOST_UTF8_BEGIN_NAMESPACE'
BOOST_UTF8_BEGIN_NAMESPACE
^
include/boost/detail/utf8_codecvt_facet.ipp:33:1: error: expected unqualified-id
namespace detail {
^
include/boost/detail/utf8_codecvt_facet.ipp:294:1: error: unknown type name 'BOOST_UTF8_END_NAMESPACE'
BOOST_UTF8_END_NAMESPACE
^
include/boost/detail/utf8_codecvt_facet.ipp:296:7: error: expected unqualified-id
#endif
      ^
7 errors generated.
INFO: Elapsed time: 1.795s, Critical Path: 1.42s
INFO: 30 processes: 12 internal, 18 darwin-sandbox.
ERROR: Build did NOT complete successfully

boost.array dependency is not resolved only on bcr ci.
Any comments are appreciated.

Vertexwahn · 2024-08-12T08:25:22Z

@wep21@fmeum The problem here seems to be boost/detail-boost-1.83.0/include/boost/detail/utf8_codecvt_facet.hpp - if you look into this header it says:

// The header is NOT STANDALONE, and is not to be included by the USER.

i.e. --process_headers_in_dependencies does not work here - I would simply drop it, comment out the feature in the build file and add a comment "Because of utf8_codecvt_facet.hpp this does not work"

modules/boost.detail/1.83.0/MODULE.bazel

fmeum · 2024-08-12T09:00:39Z

@wep21@fmeum The problem here seems to be boost/detail-boost-1.83.0/include/boost/detail/utf8_codecvt_facet.hpp - if you look into this header it says:
// The header is NOT STANDALONE, and is not to be included by the USER.
i.e. --process_headers_in_dependencies does not work here - I would simply drop it, comment out the feature in the build file and add a comment "Because of utf8_codecvt_facet.hpp this does not work"

If the header is not meant to be included by the user, but is still included by other files in the target, it should be excluded from the hdrs glob and instead added to textual_headers. This is preferable to disabling the check.

Vertexwahn · 2024-08-12T09:33:56Z

I tried this for overlay/BUILD.bazel

load("@rules_cc//cc:defs.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

cc_library(
    name = "boost.detail",
    hdrs = glob(
        [
            "include/**/*.hpp",
            "include/**/*.h",
            "include/**/*.ipp",
        ],
        exclude = [
            "include/boost/detail/utf8_codecvt_facet.hpp",
            "include/boost/detail/utf8_codecvt_facet.ipp",
        ],
    ),
    features = [
        "parse_headers",
    ],
    includes = ["include"],
    textual_hdrs = [
        "include/boost/detail/utf8_codecvt_facet.hpp",
    ],
    deps = [
        "@boost.config",
        "@boost.core",
        "@boost.preprocessor",
        "@boost.static_assert",
        "@boost.type_traits",
    ],
)

All tests work, except //:test_utf8_codecvt

Vertexwahn · 2024-08-12T10:11:06Z

I recommend to comment out the test_utf8_codecvt for now. There seem to be 3 more tests under test/container_fwd - maybe those could also be bazelized - you could add: overlay/test/container_fwd/BUILD.bazel with the following content:

cc_test(
    name = "container_fwd_test",
    srcs = ["container_fwd_test.cpp"],
    deps = [
        "@boost.detail",
    ],
)

cc_test(
    name = "container_no_fwd_test",
    srcs = ["container_no_fwd_test.cpp"],
    deps = [
        "@boost.detail",
    ],
)

cc_test(
    name = "correctly_disable_fail",
    srcs = ["correctly_disable_fail.cpp"],
    deps = [
        "@boost.detail",
    ],
)

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 · 2024-08-13T18:21:24Z

@Vertexwahn

I recommend to comment out the test_utf8_codecvt for now. There seem to be 3 more tests under test/container_fwd - maybe those could also be bazelized - you could add: overlay/test/container_fwd/BUILD.bazel with the following content:

I have encountered another build issues when adding the tests you suggested, so I gave up adding it once.

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/search_n.h:77:6: error: reference to 'pair' is ambiguous
std::pair<_Iter, _Iter> __search_n_random_access_impl(_Iter __first, _Sent __last,
     ^
include/boost/detail/container_fwd.hpp:145:42: note: candidate found by name lookup is 'std::pair'
    template <class T1, class T2> struct pair;
                                         ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__utility/pair.h:81:29: note: candidate found by name lookup is 'std::__1::pair'
struct _LIBCPP_TEMPLATE_VIS pair
                            ^
In file included from test/container_fwd/correctly_disable_fail.cpp:34:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/vector:321:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/formatter_bool.h:17:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/concepts.h:17:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/format_parse_context.h:16:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/string_view:1059:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/algorithm:1908:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/ranges_unique.h:14:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/unique.h:29:80: error: reference to 'pair' is ambiguous
_LIBCPP_NODISCARD_EXT _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 std::pair<_Iter, _Iter>
                                                                               ^
include/boost/detail/container_fwd.hpp:145:42: note: candidate found by name lookup is 'std::pair'
    template <class T1, class T2> struct pair;
                                         ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__utility/pair.h:81:29: note: candidate found by name lookup is 'std::__1::pair'
struct _LIBCPP_TEMPLATE_VIS pair
                            ^
In file included from test/container_fwd/correctly_disable_fail.cpp:34:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/vector:321:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/formatter_bool.h:17:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/concepts.h:17:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/format_parse_context.h:16:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/string_view:1059:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/algorithm:1908:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/ranges_unique.h:14:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/unique.h:40:17: error: reference to 'pair' is ambiguous
    return std::pair<_Iter, _Iter>(std::move(__first), std::move(__i));
                ^
include/boost/detail/container_fwd.hpp:145:42: note: candidate found by name lookup is 'std::pair'
    template <class T1, class T2> struct pair;
                                         ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__utility/pair.h:81:29: note: candidate found by name lookup is 'std::__1::pair'
struct _LIBCPP_TEMPLATE_VIS pair
                            ^
In file included from test/container_fwd/correctly_disable_fail.cpp:34:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/vector:321:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/formatter_bool.h:17:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/concepts.h:17:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/format_parse_context.h:16:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/string_view:1059:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/algorithm:1908:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/ranges_unique.h:14:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/unique.h:42:15: error: reference to 'pair' is ambiguous
  return std::pair<_Iter, _Iter>(__first, __first);
              ^
include/boost/detail/container_fwd.hpp:145:42: note: candidate found by name lookup is 'std::pair'
    template <class T1, class T2> struct pair;
                                         ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__utility/pair.h:81:29: note: candidate found by name lookup is 'std::__1::pair'
struct _LIBCPP_TEMPLATE_VIS pair
                            ^
test/container_fwd/correctly_disable_fail.cpp:38:10: error: reference to 'vector' is ambiguous
    std::vector<int> x;
         ^
include/boost/detail/container_fwd.hpp:135:47: note: candidate found by name lookup is 'std::vector'
    template <class T, class Allocator> class vector;
                                              ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/vector:383:28: note: candidate found by name lookup is 'std::__1::vector'
class _LIBCPP_TEMPLATE_VIS vector
                           ^
test/container_fwd/correctly_disable_fail.cpp:38:10: error: too few template arguments for class template 'vector'
    std::vector<int> x;
         ^
include/boost/detail/container_fwd.hpp:135:47: note: template is declared here
    template <class T, class Allocator> class vector;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~       ^
8 errors generated.
INFO: Elapsed time: 0.506s, Critical Path: 0.41s
INFO: 4 processes: 4 internal.
ERROR: Build did NOT complete successfully

wep21 · 2024-08-13T18:22:10Z

@Vertexwahn @fmeum I would appreciate it if you could review again.

modules/boost.detail/1.83.0/MODULE.bazel

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

Require module maintainers' approval for newly pushed changes.

meteorcloudy · 2024-08-14T07:57:09Z

@Vertexwahn Please take a final look, if all looks good, just resolve the comments to get this merged.

Vertexwahn · 2024-08-14T07:58:43Z

@meteorcloudy LGTM

wep21 force-pushed the add-boost.detail branch from f1a66c0 to 08252f7 Compare August 10, 2024 14:12

fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Aug 10, 2024

Vertexwahn previously approved these changes Aug 10, 2024

View reviewed changes

feat: add boost.detail

c0c9c5b

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 force-pushed the add-boost.detail branch from 08252f7 to c0c9c5b Compare August 11, 2024 15:06

Vertexwahn reviewed Aug 11, 2024

View reviewed changes

modules/boost.detail/1.83.0/MODULE.bazel Show resolved Hide resolved

Vertexwahn reviewed Aug 11, 2024

View reviewed changes

modules/boost.detail/1.83.0/presubmit.yml Outdated Show resolved Hide resolved

Vertexwahn reviewed Aug 11, 2024

View reviewed changes

modules/boost.detail/1.83.0/overlay/BUILD.bazel Show resolved Hide resolved

wep21 requested review from Vertexwahn and fmeum August 11, 2024 23:07

wep21 force-pushed the add-boost.detail branch 4 times, most recently from 7934d30 to 817d2d9 Compare August 12, 2024 04:17

address review

01dd066

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 force-pushed the add-boost.detail branch from 817d2d9 to 01dd066 Compare August 12, 2024 04:30

Vertexwahn reviewed Aug 12, 2024

View reviewed changes

modules/boost.detail/1.83.0/MODULE.bazel Outdated Show resolved Hide resolved

Vertexwahn mentioned this pull request Aug 12, 2024

Bringing rules_boost to BCR nelhage/rules_boost#573

Open

address review

a67bba8

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

wep21 requested a review from Vertexwahn August 13, 2024 18:22

Vertexwahn reviewed Aug 13, 2024

View reviewed changes

modules/boost.detail/1.83.0/MODULE.bazel Outdated Show resolved Hide resolved

Vertexwahn previously approved these changes Aug 13, 2024

View reviewed changes

alphabetical order

32c0052

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>

meteorcloudy approved these changes Aug 14, 2024

View reviewed changes

meteorcloudy enabled auto-merge (squash) August 14, 2024 07:56

Vertexwahn approved these changes Aug 14, 2024

View reviewed changes

meteorcloudy merged commit 678740d into bazelbuild:main Aug 14, 2024
19 checks passed

wep21 deleted the add-boost.detail branch August 14, 2024 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add boost.detail #2580

feat: add boost.detail #2580

wep21 commented Aug 10, 2024

bazel-io commented Aug 10, 2024

Vertexwahn commented Aug 10, 2024 •

edited

Loading

wep21 commented Aug 12, 2024

Vertexwahn commented Aug 12, 2024 •

edited

Loading

fmeum commented Aug 12, 2024 •

edited

Loading

Vertexwahn commented Aug 12, 2024

Vertexwahn commented Aug 12, 2024 •

edited

Loading

wep21 commented Aug 13, 2024

wep21 commented Aug 13, 2024

meteorcloudy commented Aug 14, 2024

Vertexwahn commented Aug 14, 2024 •

edited

Loading

feat: add boost.detail #2580

feat: add boost.detail #2580

Conversation

wep21 commented Aug 10, 2024

bazel-io commented Aug 10, 2024

Vertexwahn commented Aug 10, 2024 • edited Loading

wep21 commented Aug 12, 2024

Vertexwahn commented Aug 12, 2024 • edited Loading

fmeum commented Aug 12, 2024 • edited Loading

Vertexwahn commented Aug 12, 2024

Vertexwahn commented Aug 12, 2024 • edited Loading

wep21 commented Aug 13, 2024

wep21 commented Aug 13, 2024

meteorcloudy commented Aug 14, 2024

Vertexwahn commented Aug 14, 2024 • edited Loading

Vertexwahn commented Aug 10, 2024 •

edited

Loading

Vertexwahn commented Aug 12, 2024 •

edited

Loading

fmeum commented Aug 12, 2024 •

edited

Loading

Vertexwahn commented Aug 12, 2024 •

edited

Loading

Vertexwahn commented Aug 14, 2024 •

edited

Loading