Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add libarmgpuinfo@1.1.0+11140bec96 #2641

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

mattyclarkson
Copy link
Contributor

Uses an unstable archive at the moment. Will work with upstream to publish a stable archive for the next release.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (libarmgpuinfo) have been updated in this PR. Please review the changes.

@mattyclarkson
Copy link
Contributor Author

ARM-software/libGPUInfo#15 raised to track adding a stable archive to the releases.

@meteorcloudy meteorcloudy added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Aug 19, 2024
@meteorcloudy
Copy link
Member

It would be nice if other patches could be upstreamed in the next version.

@meteorcloudy meteorcloudy merged commit 75d1b78 into bazelbuild:main Aug 19, 2024
11 checks passed
@mattyclarkson mattyclarkson deleted the libarmgpuinfo branch August 19, 2024 16:07
@mattyclarkson
Copy link
Contributor Author

@meteorcloudy the following does not work:

$ cd $(mktemp -d)
$ cat <<EOF >MODULE.bazel
module(name = "demo")
bazel_dep(name = "libarmgpuinfo", version = "1.1.0+11140bec96")
EOF
$ bazel build @libarmgpuinfo
ERROR: Error computing the main repository mapping: module not found in registries: libarmgpuinfo@1.1.0

It seems the metadata part of the semantic version is being ignored (the + and after). Shall I file this as a bug?

@meteorcloudy
Copy link
Member

meteorcloudy commented Aug 20, 2024

Build metadata after + is ignored when doing version comparison according to https://bazel.build/external/module#version_format and https://semver.org/#spec-item-10, and after bazelbuild/bazel#23127, it's actually impossible for Bzlmod to support this version format as + has a special meaning in canonical repo name.

@meteorcloudy
Copy link
Member

If we want this to work, we should have checked it in under 1.1.0 instead of 1.1.0+11140bec96.

@mattyclarkson
Copy link
Contributor Author

Understood, thanks for the explaination. Using it as 1.1.0 in MODULE.bazel makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants