Rename com_google_protobuf to protobuf #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to cherrypick your CL adding "protobuf" as a well-known module name into 5.0? Would people run into issues if they try to build Bazel with --experimental_enable_bzlmod? |
|
Good point, we should probably cherry-pick that. |
|
How does the cherry-pick work nowadays? Should I send a PR? |
|
Yeah, just send a PR to the release-5.0.0rc1 branch. |
|
Done at bazelbuild/bazel#14195 |
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Oct 29, 2021
Context: bazelbuild/bazel-central-registry#28 RELNOTES: None PiperOrigin-RevId: 406334617
|
Oh no, I'm getting the following error while building Bazel: This happens when the module name is different from the commonly used workspace name in the WORKSPACE file, because the repo itself will no longer be able to access targets of itself under the previous repo name... Maybe we need to add an attribute |
meteorcloudy
added a commit
to meteorcloudy/bazel
that referenced
this pull request
Nov 4, 2021
Modules can specify the workspace_name attribute to allow accessing its own targets under the repo name. This helps make migration easier when the preferred workspace name is different from the module name of the project. Context: bazelbuild/bazel-central-registry#28 (comment)
Wyverald
added a commit
to Wyverald/protobuf
that referenced
this pull request
Nov 4, 2021
The label `@com_google_protobuf//:foo` within the protobuf repo is often synonymous with just `//:foo`. We should prefer the latter as it allows us to use a shorter name for the module in the Bazel Central Registry (so just "protobuf" instead of "com_google_protobuf"). Note that the semantics can be subtle: in a macro, plain strings are anchored to the *calling* repo, so if we just use `//:foo` as the default value of a macro argument, it will be resolved to `@myrepo//:foo` if the macro is called from the repo `@myrepo`. In this case, it's necessary to directly call the `Label()` constructor to anchor the string label to the repo where the .bzl file lives. See bazelbuild/bazel-central-registry#28 (comment) for a bit more context.
acozzette
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Nov 4, 2021
* Use repo-relative labels wherever possible The label `@com_google_protobuf//:foo` within the protobuf repo is often synonymous with just `//:foo`. We should prefer the latter as it allows us to use a shorter name for the module in the Bazel Central Registry (so just "protobuf" instead of "com_google_protobuf"). Note that the semantics can be subtle: in a macro, plain strings are anchored to the *calling* repo, so if we just use `//:foo` as the default value of a macro argument, it will be resolved to `@myrepo//:foo` if the macro is called from the repo `@myrepo`. In this case, it's necessary to directly call the `Label()` constructor to anchor the string label to the repo where the .bzl file lives. See bazelbuild/bazel-central-registry#28 (comment) for a bit more context. * fix protobuf_deps.bzl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.