fix: genproto google apis conflict fix #1922
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Sep 14, 2024
| @@ -102,6 +102,10 @@ DEFAULT_DIRECTIVES_BY_PATH = { | |||
| "gazelle:go_generate_proto false", | |||
| "gazelle:proto_import_prefix k8s.io/apimachinery", | |||
| ], | |||
| "google.golang.org/genproto/googleapis/api/annotations": [ | |||
| "gazelle:resolve go google.golang.org/genproto/googleapis/api/annotations @org_golang_google_genproto//googleapis/api/annotations", | |||
There was a problem hiding this comment.
Based on the comment you linked, it sounds like we should depend on the repo corresponding to the Go submodule, not this one. Could you confirm what's correct?
There was a problem hiding this comment.
oh, so I should replace L105 with google.golang.org/genproto/googleapis/api then
There was a problem hiding this comment.
or I guess we should do google.golang.org/genproto?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses rules_go issue 1877.
This is a fairly good description of what's happening: the target dependency isn't accurate.
As suggested by @fmeum I added the default behaviour to prevent this issue from happening.