do not generate an empty rule if a go_proto_library was already gener… #1927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Prevents overwriting of a generated
go_proto_library
in the case where the package name matches the proto file name. See issue for more details.Which issues(s) does this PR fix?
Fixes #1926
Other notes for review
Unclear exactly how to write a test for it, but did local testing at least.