Fix repository for compatibility with --incompatible_no_support_tools_in_action_inputs #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_in_action_inputs
thomasvl
approved these changes
May 23, 2019
rules/run_binary.bzl
Outdated
| @@ -44,7 +44,8 @@ def _impl(ctx): | |||
| } | |||
| ctx.actions.run( | |||
| outputs = ctx.outputs.outs, | |||
| inputs = depset(direct = ctx.files.srcs, transitive = [tool_inputs]), | |||
| inputs = depset(direct = ctx.files.srcs), | |||
There was a problem hiding this comment.
Can inputs just be ctx.files.srcs or does it have to be wrapped in a depset?
There was a problem hiding this comment.
Thanks, the depset was indeed useless
| @@ -48,7 +48,7 @@ def copy_cmd(ctx, src, dst): | |||
|
|
|||
| def copy_bash(ctx, src, dst): | |||
| ctx.actions.run_shell( | |||
| inputs = [src], | |||
| tools = [src], | |||
There was a problem hiding this comment.
Why this change?
I believe we need target-config here, which I believe inputs is but tools isn't. Maybe I'm missing something?
There was a problem hiding this comment.
Found tool(s) 'bazel-out/host/bin/tests/run_binary/printargs' in inputs. A tool is an input with executable=True set. All tools should be passed using the 'tools' argument instead of 'inputs' in order to make their runfiles available to the action. This safety check will not be performed once the action is modified to take a 'tools' argument. To temporarily disable this check, set --incompatible_no_support_tools_in_action_inputs=false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.