-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Gazelle language for Starlark #251
Conversation
Looking over the buildkite results, 2 things stand out:
Overall I don't think these are review blockers since this is intended to advance conversation and would still appreciate, if you're comfortable, you taking a look at the PR. If you're not, can you please leave a comment informing me what preconditions will need to be met before you'll review? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on a quick first pass. Generally looks good though.
Thanks for the PR, @achew22! Would you like to be a maintainer for this directory? |
@laurentlb, yes I would be happy to be a maintainer |
I gave you write access to the repository. Can you update the CodeOwners file in the same PR? @aiuto, @jayconrod, other code review comments? |
eb280c9
to
2b4ebd8
Compare
@jayconrod PTAL, I believe I've addressed all your comments, but historically I've found this hard in GitHub as opposed to critique. Additionally, I've added you to the @laurentlb, I've included myself as a I don't believe it is possible for anyone to submit a PR to this repo right now. Is there a way to configure your Copybara exporter to run BuildKite before pushing? I've opened an issue with the continuous-integration repo to track this in addition. What is the best way for me to proceed here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Couple more small comments. Otherwise LGTM.
(Completely agree that GitHub reviews are difficult.)
@jayconrod thanks for your review! Once #254 is merged, I believe all the lint errors are fixed which means this CL will now pass CI and can be merged. |
@jayconrod and @aiuto, now that bazelbuild/buildtools#870 is submitted, once the ci server is updated this should be entirely green. PTAL. Thanks! |
LGTM, though I don't have submit powers in this repo. I think this would be fine to merge after the conflict in |
@laurentlb looks like we are good to go then. PTAL and thanks for your help |
@aiuto or @laurentlb, friendliest of pings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is a companion to #250 to provide a strawman for a Gazelle language extension.
Callouts:
gazelle/testdata/README.md
. This is intended to be pretty comprehensive, but I wouldn't be surprised if there are additional oddities that I couldn't think of in the heat of the moment. If you're aware of additional edge cases I am happy to test them out.go.starlark.net
(not @mentioned unless one of you thinks it's necessary) in the rootWORKSPACE
. I'm 100% sure that is wrong and I figured I would just ask to figure out the right way to do this since there are a lot of moving parts aroundbazel_federation
.CC: @aiuto @jayconrod